sammccall added a comment.
Thanks for doing this, clangd change LGTM.
================
Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:726
EXPECT_EQ("CXXConstructExpr", nodeKind(Str->Parent->Parent));
EXPECT_EQ(Str, &Str->Parent->Parent->ignoreImplicit())
<< "Didn't unwrap " << nodeKind(&Str->Parent->Parent->ignoreImplicit());
----------------
Huh, i actually think something is wrong here (ignoreImplicit and outerImplicit
seem to disagree on whether the CXXConstructExpr is implicit).
In any case, this is already wrong today in C++17 mode.
Would you mind adding `// FIXME: is CXXConstructExpr implicit or not` and I'll
look at it later?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131465/new/
https://reviews.llvm.org/D131465
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
