aaron.ballman added a comment.

Precomit CI found valid failures that seem plausibly related to your changes, 
but Windows and Debian found different failures which is a bit of a surprise to 
me. Can you check those?



================
Comment at: clang/test/lit.site.cfg.py.in:27
 config.clang_enable_opaque_pointers = @CLANG_ENABLE_OPAQUE_POINTERS_INTERNAL@
+config.clang_default_std_cxx = "@CLANG_DEFAULT_STD_CXX@"
 config.clang_default_cxx_stdlib = "@CLANG_DEFAULT_CXX_STDLIB@"
----------------
Should we add some documentation for this in a follow-up? (I know 
`CLANG_DEFAULT_STD_CXX` already exists, but it seems like it'd be helpful to 
tell users about it too.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131465/new/

https://reviews.llvm.org/D131465

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to