MaskRay added a subscriber: mgorny. MaskRay added inline comments.
================ Comment at: clang/test/lit.site.cfg.py.in:27 config.clang_enable_opaque_pointers = @CLANG_ENABLE_OPAQUE_POINTERS_INTERNAL@ +config.clang_default_std_cxx = "@CLANG_DEFAULT_STD_CXX@" config.clang_default_cxx_stdlib = "@CLANG_DEFAULT_CXX_STDLIB@" ---------------- aaron.ballman wrote: > Should we add some documentation for this in a follow-up? (I know > `CLANG_DEFAULT_STD_CXX` already exists, but it seems like it'd be helpful to > tell users about it too.) Where shall we place the documentation? My understanding is that we don't document lit.* config changes. Personally I think we probably should get rid of `CLANG_DEFAULT_STD_CXX` (D34365 @mgorny), which may require improvements to Clang configuration file (https://discourse.llvm.org/t/configuration-files/42529 https://clang.llvm.org/docs/UsersManual.html#configuration-files). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131465/new/ https://reviews.llvm.org/D131465 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
