ymandel added inline comments.
================ Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:208 + + // TODO: Currently this only works if the callee is never a method and the + // same callee is never analyzed from multiple separate callsites. To ---------------- samestep wrote: > ymandel wrote: > > > OK, I'll change this; would you like for me to replace all the other `TODO`s > with `FIXME`s, as well? Just those in this patch. ================ Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:220 + assert(Body != nullptr); + initGlobalVars(*Body, Env); + ---------------- samestep wrote: > ymandel wrote: > > I wonder how this will work between caller and callee. Do we need separate > > global var state in the frame? If so, maybe mention that as well in the > > FIXME above. > Could you clarify what you mean? Perhaps I just don't understand exactly what > is meant by "global vars" here. https://github.com/llvm/llvm-project/blob/main/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp#L131-L135 ``` /// Initializes global storage values that are declared or referenced from /// sub-statements of `S`. // FIXME: Add support for resetting globals after function calls to enable // the implementation of sound analyses. ``` Since this already mentions a need to reset after function calls, seemed relevant here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130306/new/ https://reviews.llvm.org/D130306 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
