kwk added a comment. In D120712#3352051 <https://reviews.llvm.org/D120712#3352051>, @MyDeveloperDay wrote:
> Does it need to be so "cloak and dagger"? ;-) No, you're right it doesn't have to be this way. > We always welcome patches, but please think about logging the idea in github > issues (and assigning it to yourself), and use the good will of the regular > contributors to give you some feedback/advice (you never know we might know a > thing or too) Fair enough. > I'd like to see this review in the context of what you are proposing. I know > it doesn't do any actual harm on its own, but its doesn't actually do > anything, as such its technical debt right? we have to maintain and support > it when it goes wrong (it will unlikely go wrong, but it could I guess). > > My suggestion is to hold off this patch until you have something that needs > it then submit the reviews at the same time and mark with a dependency. > (@curdeius, @HazardyKnusperkeks, @owenpan am I being fair?) That sounds like a plan. > Please also consider being more open about what you intend to work on, you > never know we could save you time and effort. Plus remember you'll want one > of us to review the changes so its good to build good relationships with the > key contributors and get their input. To be honest, I'm rather new to the clang-format code base and plan on adding something for which I'd like to do the work. I've took your advice and create this github issue: https://github.com/llvm/llvm-project/issues/54137 . I look forward to comments on it. I really want to establish a good relationship and I appreciate that you kindly tell me about this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120712/new/ https://reviews.llvm.org/D120712 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
