LegalizeAdulthood added a comment. In D56303#3272711 <https://reviews.llvm.org/D56303#3272711>, @aaron.ballman wrote:
> The rule of thumb is: if you have significant NFC changes, > do them first and push the changes (often doesn't even > require a review because it's NFC, but that depends on > what comfort level you have about the changes being NFC), > and then do the functional changes on top of the improved > code. This is reasonable, but is it written down anywhere so that people don't have to through this trial by fire every time? `:)` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56303/new/ https://reviews.llvm.org/D56303 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
