LegalizeAdulthood added a comment. In D56303#3266252 <https://reviews.llvm.org/D56303#3266252>, @njames93 wrote:
> A large portion of the changes, especially in the checks implementation file, > appear to be NFC stylistic or formatting only fixes. While these changes are > generally good, they shouldn't be a part of this patch. Instead they should > be committed in their own NFC patch. > This makes it much easier to review the relevant changes needed to implement > this new behaviour. It's going to be a significant amount of work to tease everything apart and this patch has already been waiting literally for years. Every time I put something up for review I get told "do this because the style guide says so", so I anticipated those things and fixed them pre-emptively. Honestly, we need to make our review process more productive, not less. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56303/new/ https://reviews.llvm.org/D56303 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
