LegalizeAdulthood added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:72-73 -const Expr *getBoolLiteral(const MatchFinder::MatchResult &Result, - StringRef Id) { +static const Expr *getBoolLiteral(const MatchFinder::MatchResult &Result, + StringRef Id) { if (const Expr *Literal = Result.Nodes.getNodeAs<CXXBoolLiteralExpr>(Id)) ---------------- LegalizeAdulthood wrote: > FYI > > These tabs here (and elsewhere) are phantoms somehow > introduced into the diff by Phabricator. My local diff file > that I uploaded has zero tabs in it anywhere. > When I look more carefully, I see it's one column to the left of the first column in the file.... so it's trying to somehow say that this line had increased indent in the diff? I thought it was a TAB indicator and another reviewer thought so as well. But it isn't a TAB at all `:)` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56303/new/ https://reviews.llvm.org/D56303 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits