steakhal added a comment.

In D103317#3155191 <https://reviews.llvm.org/D103317#3155191>, @martong wrote:

>> Please repeat the measurement for `openssl`. There must have been some 
>> interference in the memory consumption. Aside from that the results look 
>> great.
>
> I did. Average memory usage is unaffected.
>
> F20722167: svalbuilder_improvements_openssl.png 
> <https://reviews.llvm.org/F20722167>
>
> F20722178: stats.html <https://reviews.llvm.org/F20722178>

It's good enough for me, thanks.



================
Comment at: clang/test/Analysis/svalbuilder-simplify-compound-svals.cpp:75
+      if (b * b == 1)
+        ; // no-crash (assertion should not be violated)
+  }
----------------
I guess, this statement should not be reachable.
Please demonstrate it by using the `clang_analyzer_WarnIfReached()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103317/new/

https://reviews.llvm.org/D103317

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to