steakhal added a comment. In D103317#3148868 <https://reviews.llvm.org/D103317#3148868>, @martong wrote:
> In D103317#3127318 <https://reviews.llvm.org/D103317#3127318>, @steakhal > wrote: > >> To me at least, the patch looks good. >> Please post some comparative measurements to demonstrate it won't introduce >> runtime regression. > > Sure! > > F20586670: stats.html <https://reviews.llvm.org/F20586670> > > Teaser: > F20586689: svalbuilder_improvements.png <https://reviews.llvm.org/F20586689> Please repeat the measurement for `openssl`. There must have been some interference in the memory consumption. Aside from that the results look great. ================ Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1105 - // FIXME: Add support for SymExprs. return nullptr; ---------------- Where did you address this FIXME? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103317/new/ https://reviews.llvm.org/D103317 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
