steakhal added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1105 - // FIXME: Add support for SymExprs. return nullptr; ---------------- martong wrote: > steakhal wrote: > > Where did you address this FIXME? > I didn't, but this `FIXME` became obsolete at some point in the past. > > The reasons: > 1) We do support `SymExprs`. In `simplifySVal` we have a full blown SymExpr > visitor implemented that checks for constant values in the symbol subtrees. > And at L1103 we query the top symbol of tree as well. > > 2) The git history shows that the FIXME was previously this: `// FIXME: Add > support for SymExprs in RangeConstraintManager.` But we do support SymExprs > already in RangeConstraintManager ... > Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103317/new/ https://reviews.llvm.org/D103317 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
