dougpuob added a comment. In D86671#2754542 <https://reviews.llvm.org/D86671#2754542>, @njames93 wrote:
> In D86671#2750957 <https://reviews.llvm.org/D86671#2750957>, @dougpuob wrote: > >> Hi @njames93: >> Could you do me a favor? Because it is my first patch, something I'm not >> sure. I'm confused about can I land this patch now? I read the "LLVM >> Code-Review Policy and Practices" document, it said patches can be landed if >> received a LGTM, but seems you are still reviewing. > > If you have made significant changes (excluding what a reviewer asks when > giving an LGTM) Its best to get those further changes also reviewed. Thank you for your reply and suggestion in code, I will try it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ https://reviews.llvm.org/D86671 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
