njames93 added a comment. Sorry, I thought this landed months ago. I'll take a proper look again next week.
================ Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:158 + /// name \p LocalName shoud not present. + void diagnoseInvalidConfigOption(StringRef LocalName) const; + ---------------- This isn't really needed, you can just call `configurationDiag` directly. ================ Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:450 + if (!isHungarianNotationSupportedStyle(I) && HPTOpt.hasValue()) + Options.diagnoseInvalidConfigOption(StyleString); + StyleString.resize(StyleSize); ---------------- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ https://reviews.llvm.org/D86671 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
