ChuanqiXu added a comment.

In D99227#2646719 <https://reviews.llvm.org/D99227#2646719>, @lxfind wrote:

> In D99227#2646568 <https://reviews.llvm.org/D99227#2646568>, @ChuanqiXu wrote:
>
>> Only one problem I had for emitting lifetime markers even at O0 is that 
>> would action make allocas to be optimized even at O0? If so, I wonder if it 
>> confuses programmers since they may find some variables disappear 
>> surprisingly. Or there would be no optimization since every function would 
>> be marked with optnone attribute. I am not sure about this.
>
> It will only cause variables to be put on the stack instead of on the frame, 
> which shouldn't affect developer's view?

Yes, I am just worry about the variable marked with lifetime intrinsic would be 
optimized by other passes. But functions would get attribute `optnone` in O0, 
my worries may be redundant. Then it is Ok to me to emit lifetime intrinsics 
all the time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99227/new/

https://reviews.llvm.org/D99227

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to