aaron.ballman added a comment. In D94880#2544782 <https://reviews.llvm.org/D94880#2544782>, @steveire wrote:
> @aaron.ballman Any further comments? Thank you for pinging, this fell off my queue! The only further comments I have about about my confusion with `with`. In D94880#2536485 <https://reviews.llvm.org/D94880#2536485>, @steveire wrote: > In D94880#2536399 <https://reviews.llvm.org/D94880#2536399>, @aaron.ballman > wrote: > >> I think there should be some documentation change for the new `with` >> functionality. > > It's already documented in > https://clang.llvm.org/docs/LibASTMatchersReference.html , just like all the > other functionality. Perhaps I'm blind, but when I search for "with" on that page, I get 21 hits and none of them are about the `with()` function. I am not finding evidence of `with` being supported on ToT, can you point me to the existing implementation? (If the functionality isn't being introduced in this patch, you don't need to document as part of this work. However, I was under the impression you were adding this functionality, so I'd like to understand this situation better before approving.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94880/new/ https://reviews.llvm.org/D94880 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
