steveire added a comment. In D94880#2544895 <https://reviews.llvm.org/D94880#2544895>, @aaron.ballman wrote:
> In D94880#2544873 <https://reviews.llvm.org/D94880#2544873>, @steveire wrote: > >> That page collapses the documentation for each matcher, as you know. >> >> You need to expand the docs for `mapAnyOf`, as you know. >> >> You seem to know all this. What's the remaining issue? > > The issue was that this was not at all obvious to me as a code reviewer, so I > was asking you for help. Your response comes across as patronizing, but thank > you for giving me the information I was looking for. FWIW, I did not know > this was under the `mapAnyOf` matcher and I was assuming this was going to be > documented at the top level, just like `bind()`. > > LG. You reviewed the patches for `mapAnyOf` up to now and you reviewed this change which has unit tests using `with`. I didn't know what was unclear to you. Sorry for being terse. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94880/new/ https://reviews.llvm.org/D94880 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
