kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:695
+ Callback<llvm::Optional<std::vector<CallHierarchyIncomingCall>>> CB) {
+ CB(clangd::incomingCalls(Item, Index));
+}
----------------
nridge wrote:
> kadircet wrote:
> > why do we run this on the mainthread ? I suppose we should just do
> > `WorkScheduler.run`
> I was following what `resolveTypeHierarchy` did. Should I change that too?
yes, i think we should. preferably on a different patch though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91123/new/
https://reviews.llvm.org/D91123
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
