nridge added a comment.
In D91123#2387032 <https://reviews.llvm.org/D91123#2387032>, @kadircet wrote:
> can you also add some tests to ClangdTests.cpp ?
It seems like they would be highly duplicative of the tests in
CallHierarchyTests.cpp.
================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:695
+ Callback<llvm::Optional<std::vector<CallHierarchyIncomingCall>>> CB) {
+ CB(clangd::incomingCalls(Item, Index));
+}
----------------
kadircet wrote:
> why do we run this on the mainthread ? I suppose we should just do
> `WorkScheduler.run`
I was following what `resolveTypeHierarchy` did. Should I change that too?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91123/new/
https://reviews.llvm.org/D91123
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
