kadircet added a comment.
can you also add some tests to ClangdTests.cpp ?
================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:695
+ Callback<llvm::Optional<std::vector<CallHierarchyIncomingCall>>> CB) {
+ CB(clangd::incomingCalls(Item, Index));
+}
----------------
why do we run this on the mainthread ? I suppose we should just do
`WorkScheduler.run`
================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:701
+ Callback<llvm::Optional<std::vector<CallHierarchyOutgoingCall>>> CB) {
+ CB(clangd::outgoingCalls(Item, Index));
+}
----------------
can we reply with none/empty at clangdlsplayer directly and delete the
`outgoingCalls` from both clangdserver and xrefs.cpp ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91123/new/
https://reviews.llvm.org/D91123
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
