kadircet added a comment.

Am I missing something? We still have:

  case index::SymbolKind::Constructor:
  case index::SymbolKind::Destructor:
    return SymbolKind::Constructor;

in Protocol.cpp. E.g. Constructors and Destructors are still classified badly. 
I suppose the bit around `they're all methods` are wrong though, maybe just 
drop that bit ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89935/new/

https://reviews.llvm.org/D89935

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to