kbobyrev created this revision.
kbobyrev added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman.
Herald added a project: clang.
kbobyrev requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Both `SymbolKind` and `indexSymbolKindToSymbolKind` support constructors and
separate them into a different category from regular methods.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D89935
Files:
clang-tools-extra/clangd/FindSymbols.cpp
Index: clang-tools-extra/clangd/FindSymbols.cpp
===================================================================
--- clang-tools-extra/clangd/FindSymbols.cpp
+++ clang-tools-extra/clangd/FindSymbols.cpp
@@ -179,8 +179,8 @@
return llvm::None;
index::SymbolInfo SymInfo = index::getSymbolInfo(&ND);
- // FIXME: this is not classifying constructors, destructors and operators
- // correctly (they're all "methods").
+ // FIXME: This does not classify operators correctly, they are cosnidered
+ // methods.
SymbolKind SK = indexSymbolKindToSymbolKind(SymInfo.Kind);
DocumentSymbol SI;
Index: clang-tools-extra/clangd/FindSymbols.cpp
===================================================================
--- clang-tools-extra/clangd/FindSymbols.cpp
+++ clang-tools-extra/clangd/FindSymbols.cpp
@@ -179,8 +179,8 @@
return llvm::None;
index::SymbolInfo SymInfo = index::getSymbolInfo(&ND);
- // FIXME: this is not classifying constructors, destructors and operators
- // correctly (they're all "methods").
+ // FIXME: This does not classify operators correctly, they are cosnidered
+ // methods.
SymbolKind SK = indexSymbolKindToSymbolKind(SymInfo.Kind);
DocumentSymbol SI;
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
