Prazek added a comment. In http://reviews.llvm.org/D18821#398843, @alexfh wrote:
> BTW, why is the check in the 'modernize' module? It doesn't seem to make > anything more modern. I would guess, the pattern it detects is most likely to > result from a programming error. Also, the fix, though it retains the > behavior, has a high chance to be incorrect. Can you share the results of > running this check on LLVM? At least, how many problems it found and how many > times the suggested fix was correct. > > I'd suggest to move the check to `misc` or maybe it's time to create a > separate directory for checks targeting various bug-prone patterns. There were many places. Most of them where when assigning true/false to some member which was int. The other place was inside some functions that were returning only true or false, but the return type of this function was int, so I guess what programmer meant there was to return bool. http://reviews.llvm.org/D18821 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
