amosnier accepted this revision. amosnier added a comment. This revision is now accepted and ready to land.
I'm not sure I'm supposed to accept a revision, but apparently I'm authorized to do so. And I'm obviously biased since I wrote the bug report. While looking for candidates close to the target file might often sound reasonable, it does not feel particularly adapted to a whole category of files: template declarations. Why would the files that include those be anywhere close to them? Also, fetching compile commands from a file written in another language pretty much always seems like a bad idea. If I understand correctly, with this commit, an arbitrary file of the same language will be picked, every time one such file is found. It would of course be even better to pick one that includes the target file (in case of a header file), but I can easily imagine that it would be much more difficult to implement. Based on the previous analysis, I approve this commit. I would also like to express how impressed I am by this project's efficiency! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87253/new/ https://reviews.llvm.org/D87253 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
