sameerds added inline comments.
================
Comment at: clang/lib/AST/Decl.cpp:3227
+ !(BuiltinID == Builtin::BIprintf || BuiltinID == Builtin::BImalloc))
+ return 0;
+
----------------
sameerds wrote:
> This needs a test.
This still needs a test. One that shows that specific builtins are allowed and
others are not.
================
Comment at: clang/test/Driver/openmp-offload-gpu.c:257
// RUN: | FileCheck -check-prefix=CUDA_MODE %s
-// CUDA_MODE: clang{{.*}}"-cc1"{{.*}}"-triple" "nvptx64-nvidia-cuda"
-// CUDA_MODE-SAME: "-fopenmp-cuda-mode"
----------------
Is there a functional reason to move these lines? Changes to existing files
should be minimized to show only functional changes. Any NFC rearrangement
should be a separate patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79754/new/
https://reviews.llvm.org/D79754
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
