saiislam marked an inline comment as done. saiislam added inline comments.
================ Comment at: clang/test/OpenMP/amdgcn_device_function_call.cpp:27 + } +} ---------------- jdoerfert wrote: > Not for this patch: > FWIW, we will need to make math functions work inside target regions. The way > aomp does it is afaik different from the way we do it. We can however adopt > our way for this target though. Feel free to ping me on this later. Yes, sure. I will ping you as we move towards it. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79754/new/ https://reviews.llvm.org/D79754 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
