aaron.ballman added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:272
+ if (const auto *Typedef =
+ Value->getReturnType().getTypePtr()->getAs<TypedefType>()) {
+ addUsage(NamingCheckFailures, Typedef->getDecl(),
----------------
JonasToth wrote:
> aaron.ballman wrote:
> > logan-5 wrote:
> > > Eugene.Zelenko wrote:
> > > > Please elide braces.
> > > Would you mind pointing me toward a resource for these formatting nits? I
> > > don't see anything about requiring omitting braces for single-statement
> > > if()s in the official LLVM coding standards (and I happen to think the
> > > braces actually help readability here). If this stuff is explicitly
> > > documented somewhere and painstakingly enforced like this, I'd rather get
> > > it right the first time.
> > I looked through the coding standard and it does not suggest this, which I
> > am really surprised to see (I feel like the standard used to say it at some
> > point, but it likely got removed and I did not notice). This is a common
> > pattern that's used all over the code base (likely from fairly consistent
> > review guidance over the years), and so it's best to be consistent with the
> > style used locally, but that's a pretty weak argument for new code.
> Did it maybe get dropped? Wasn't there are overhaul a few weeks ago? But I am
> surprised as well, as this was at one point explicitly stated.
I went as far back as the 4.0 coding standards and it wasn't listed in there,
but I'm with you on remembering this being explicitly stated somewhere.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72284/new/
https://reviews.llvm.org/D72284
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
