Eugene.Zelenko added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:272
+ if (const auto *Typedef =
+ Value->getReturnType().getTypePtr()->getAs<TypedefType>()) {
+ addUsage(NamingCheckFailures, Typedef->getDecl(),
----------------
Please elide braces.
================
Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:280
+ .getTypePtr()
+ ->getAs<TypedefType>()) {
+ addUsage(NamingCheckFailures, Typedef->getDecl(),
----------------
Please elide braces.
================
Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.h:47
+ ShouldFix,
+ ConflictsWithKeyword, /// The fixup will conflict with a language keyword,
+ /// so we can't fix it automatically.
----------------
It'll be reasonable to place all comments consistently: before definition or
after.
================
Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.h:94
+
+ typedef std::pair<SourceLocation, std::string> NamingCheckId;
+
----------------
Please use using. Same below. See modernize-use-using.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72284/new/
https://reviews.llvm.org/D72284
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
