JonasToth added a comment.
I guess all the tests run?
I think this LGTM after the nits are adressed.
================
Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:203
+ Decl = Ref.getDecl();
+ }
+
----------------
What about the else? If it is unreachable it should have a
`llvm_unreachable("Reason");`, if not, i think a little fallthrough comment
wouldn't hurt.
================
Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:259
+
+ // Fix type aliases in value declarations
+ if (const auto *Value = Result.Nodes.getNodeAs<ValueDecl>("decl")) {
----------------
Please add punctuation here and in the comments below.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72284/new/
https://reviews.llvm.org/D72284
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
