hfinkel added inline comments.
================ Comment at: clang/lib/Headers/openmp_wrappers/__clang_openmp_math_declares.h:17 #if defined(__NVPTX__) && defined(_OPENMP) ---------------- Should we use a more-specific selector and then get rid of this `__NVPTX__` check? ================ Comment at: clang/lib/Parse/ParseOpenMP.cpp:1489 + ++Nesting; + } while (Nesting); + ---------------- Will this just inf-loop if the file ends? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71179/new/ https://reviews.llvm.org/D71179 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits