jdoerfert marked 6 inline comments as done.
jdoerfert added inline comments.
================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:74
+///
+///{
+namespace types {
----------------
ABataev wrote:
> Extra comments?
I don't know what you want to tell me.
================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:174-177
+ if (auto *IdentI = dyn_cast<Instruction>(Ident))
+ Call->moveAfter(IdentI);
+ else
+ Call->moveBefore(&*Fn->getEntryBlock().getFirstInsertionPt());
----------------
ABataev wrote:
> Are you sure it will work correctly with late outlining?
Yes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69785/new/
https://reviews.llvm.org/D69785
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
