jdoerfert marked 4 inline comments as done.
jdoerfert added a comment.
Anything else?
================
Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:152-155
+ std::string LineStr = std::to_string(DIL->getLine());
+ std::string ColumnStr = std::to_string(DIL->getColumn());
+ std::string SrcLocStr = (";" + Filename + ";" + Function).str() + ";" +
+ LineStr + ";" + ColumnStr + ";;";
----------------
ABataev wrote:
> better to use streams
Sure.
================
Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:169-174
+ for (Instruction &I : Fn->getEntryBlock())
+ if (CallInst *CI = dyn_cast<CallInst>(&I))
+ if (CI->getCalledFunction() &&
+ CI->getCalledFunction()->getName() == "__kmpc_global_thread_num")
+ return TID = CI;
+
----------------
ABataev wrote:
> Will it work with the late outlined parallel regions?
I'll remove the caching here. No need for it given that we will deduplicate
anyway.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69785/new/
https://reviews.llvm.org/D69785
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
