alexfh added a comment.

I think it will be a strict improvement to include the check name into the 
deduplication key (probably after the file and offset and before the message). 
I don't see any reason to hide this behind a flag or otherwise retain the old 
behavior. As for expanding the key to include notes and fixes - it's probably 
good to do this either, and this may help uncover incorrect behavior of some 
checks. I'd suggest to start with the check name though.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65065/new/

https://reviews.llvm.org/D65065



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to