bruntib added a comment.

Yes, LessClangTidyError would really be the best place for this. The reason of 
my implementation was that I wanted to bind this feature to a command line 
option. I don't know if there was any design decision behind the current 
uniquing logic and I didn't want to break it if there was any. So would you be 
agree with having duplicate reports by default without any command line flag in 
case of alias checkers? I believe this would be the most painless solution, 
since in case of further improvements about including notes, fixes, etc. in the 
functor, the potential command line option controlling this would be 
unnecessarily complex. I don't know if there could be any use-case on those.
Thanks for the review!


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65065/new/

https://reviews.llvm.org/D65065



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to