thakis added a comment.

Hello, this embeds an absolute path into the generated .obj file, which means 
the output now is no longer deterministic (since it depends on the absolute 
path to clang_rt.profile-x86_64.lib). This means the output will be different 
on different machines, which breaks things like caching in distributed builds 
and whatnot.

I can't see an obvious way to save this patch either, since you won't know at 
compile time what the CWD will be at link time.

As-is, this breaks Chromium's deterministic builds. ("Only" the coverage 
builds, and they don't yet check for determinism, which is why it took us a 
while to notice.)

Suggestions?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61742/new/

https://reviews.llvm.org/D61742



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to