rnk added a comment.

Thanks, I would like to do this for the sanitizers as well, since this is a 
constant pain point for users, who have to come up with an 
architecture-dependent filename (`clang_rt.asan-dynamic-$arch.lib` or 
something).



================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:787
     CmdArgs.push_back("-fprofile-instrument=clang");
+    if (TC.getTriple().isOSWindows()) {
+      // Add dependent lib for clang_rt.profile
----------------
This won't work with ld.bfd, so I would restrict this to a Windows MSVC 
environment. For mingw, I'd expect the user to call the compiler to link, and 
the right library path to be supplied to the linker by the compiler driver.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61742/new/

https://reviews.llvm.org/D61742



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to