compnerd added a comment.

This really needs more tests.  Please add a positive/negative test for the 
driver argument.  Please try to organise the tests a bit to show what it is 
that they are testing, emission of public functions, not of protected functions 
or hidden functions.  Behaviour with C++ classes.  Behaviour with templates.  I 
don't see any test for the vtable for classes that are public/private.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60974/new/

https://reviews.llvm.org/D60974



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to