hintonda marked an inline comment as done.
hintonda added inline comments.

================
Comment at: clang-tools-extra/clang-tidy/rename_check.py:218
   header_guard_variants = [
+      (args.old_check_name.replace('-', '_') + '_Check').upper(),
+      (old_module + '_' + check_name_camel).upper(),
----------------
alexfh wrote:
> s/_Check/_CHECK/, maybe?
Not sure it matters, but args.old_check_name is all lower case, so we have to 
uppercase the entire string.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60629/new/

https://reviews.llvm.org/D60629



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to