ABataev added inline comments.
================ Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8978 + if (Clause->getClauseKind() == OMPC_unified_shared_memory) { + CGM.getOpenMPRuntime().HasRequiresUnifiedSharedMemory = true; + break; ---------------- gtbercea wrote: > gtbercea wrote: > > ABataev wrote: > > > ABataev wrote: > > > > Just `HasRequiresUnifiedSharedMemory = true;` > > > Not done > > Ah I misunderstood your initial comment. I thought you were complaining > > about the break being in there. > Because the member is non-static I have to provide the CGM.getOpenMPRuntime() > part. Because the member function is non-static and the member data is non-static, you can just use `HasRequiresUnifiedSharedMemory = true;` ================ Comment at: test/OpenMP/openmp_offload_registration.cpp:38 +// CHECK: define internal void @.omp_offloading.requires_reg() +// CHECK: call void @__tgt_register_requires(i64 0) +// CHECK: ret void ---------------- Add a test where the unified memory flag is used Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits