gtbercea marked 2 inline comments as done.
gtbercea added inline comments.
================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8978
+ if (Clause->getClauseKind() == OMPC_unified_shared_memory) {
+ CGM.getOpenMPRuntime().HasRequiresUnifiedSharedMemory = true;
+ break;
----------------
ABataev wrote:
> ABataev wrote:
> > Just `HasRequiresUnifiedSharedMemory = true;`
> Not done
Ah I misunderstood your initial comment. I thought you were complaining about
the break being in there.
================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8978
+ if (Clause->getClauseKind() == OMPC_unified_shared_memory) {
+ CGM.getOpenMPRuntime().HasRequiresUnifiedSharedMemory = true;
+ break;
----------------
gtbercea wrote:
> ABataev wrote:
> > ABataev wrote:
> > > Just `HasRequiresUnifiedSharedMemory = true;`
> > Not done
> Ah I misunderstood your initial comment. I thought you were complaining about
> the break being in there.
Because the member is non-static I have to provide the CGM.getOpenMPRuntime()
part.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60568/new/
https://reviews.llvm.org/D60568
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
