AlexEichenberger requested changes to this revision. AlexEichenberger added a comment. This revision now requires changes to proceed.
see note above; apologies if it is already done and hiding somewhere I did not see ================ Comment at: lib/CodeGen/CGOpenMPRuntime.h:641 + /// directive is present. + bool HasRequiresUnifiedSharedMemory = false; + ---------------- Don't you need a bool for each characteristics? Your intention is to have one bit vector for each characteristics that matter to the compiler? Also, it is my belief that you need to record 2 states: unmaterialized (meaning I have not processed any target yet, so I should record any requires as they arrive) finalized (I am processing a target, so the state is now fixed) you need this in case you have an input like this: declare target int x end declare target requires unified memory which is illegal Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
