ymandel added a comment. Thank you for the extremely helpful and detailed review!!
================ Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:110 + // constructed with the builder class. + static constexpr char RootId[] = "___root___"; +}; ---------------- ilya-biryukov wrote: > NIT: `llvm::StringLiteral` is a vocabulary type with compile-time size that > could be used here. > Although I don't think it has any actual benefits over char array, so leaving > as is also looks good. Went with StringLiteral -- given that we always wrap RootId in a stringref to use it, seems better just to define it that way to begin with. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59376/new/ https://reviews.llvm.org/D59376 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
