Thanks. Any idea why AtomicChange.cpp's inclusion of clang/Tooling/ReplacementsYaml.h doesn't cause the same problem? https://github.com/llvm/llvm-project/blob/master/clang/lib/Tooling/Refactoring/AtomicChange.cpp
On Wed, Apr 3, 2019 at 2:11 PM Alexey Bataev <a.bat...@outlook.com> wrote: > The problem is that libToolingRefactor is a part of libTooling. And you > have the dependency from the Tooling/Refactor subdirectory to the outer one > Tooling/ directory. And it means that libToolingRefactor is a part of > libTooling, but it must depend on libTooling itself. > > ------------- > Best regards, > Alexey Bataev > > 03.04.2019 14:08, Yitzhak Mandelbaum пишет: > > Alexey, thanks for reverting the change. Can you expand on why a > dependency from libToolingRefactor to libTooling causes a cycle in the dep > graph? In particular, I can't find the reverse dependency libTooling -> > libToolingRefactor. If you can expand on that (I presume its a chain rather > than a direct dependency?) that would be really helpful. > > thanks! > > On Wed, Apr 3, 2019 at 1:29 PM Yitzhak Mandelbaum <yitzh...@google.com> > wrote: > >> I'll revert the change. >> >> On Wed, Apr 3, 2019 at 1:00 PM Yitzhak Mandelbaum <yitzh...@google.com> >> wrote: >> >>> https://reviews.llvm.org/D60213 for the record >>> >>> On Wed, Apr 3, 2019 at 12:55 PM Yitzhak Mandelbaum <yitzh...@google.com> >>> wrote: >>> >>>> Thanks. Do you have build command I can run before/after to verify my >>>> fix before I submit? >>>> >>>> On Wed, Apr 3, 2019 at 12:43 PM Alexey Bataev via Phabricator < >>>> revi...@reviews.llvm.org> wrote: >>>> >>>>> ABataev added a comment. >>>>> >>>>> Patch breaks the build with the shared libraries, for example, >>>>> http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage/builds/9498. >>>>> Seems to me, you need to add an extra dependency on clangTooling. >>>>> clangToolingCore is not enough. >>>>> >>>>> >>>>> Repository: >>>>> rC Clang >>>>> >>>>> CHANGES SINCE LAST ACTION >>>>> https://reviews.llvm.org/D59376/new/ >>>>> >>>>> https://reviews.llvm.org/D59376 >>>>> >>>>> >>>>> >>>>>
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
