ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land.
Looks great, thanks! ================ Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:110 + // constructed with the builder class. + static constexpr char RootId[] = "___root___"; +}; ---------------- NIT: `llvm::StringLiteral` is a vocabulary type with compile-time size that could be used here. Although I don't think it has any actual benefits over char array, so leaving as is also looks good. ================ Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:113 + +/// A fluent, builder class for \c RewriteRule. See comments on \c RewriteRule, +/// above. ---------------- NIT: comma seems redundant, this should probably be: `A fluent builder class` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59376/new/ https://reviews.llvm.org/D59376 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
