CaseyCarter requested changes to this revision. CaseyCarter added inline comments. This revision now requires changes to proceed.
================ Comment at: test/std/strings/basic.string/string.cons/copy_alloc.pass.cpp:128 + // but the standard only requires the basic guarantee: + _LIBCXX_ASSERT(s1 == p1); + s1.clear(); // under the basic guarantee, s1 must still be a valid string object. ---------------- `LIBCPP_ASSERT(s1 == p1)` (NB: no leading underscore) in test code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60023/new/ https://reviews.llvm.org/D60023 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
