BillyONeal marked 2 inline comments as done.
BillyONeal added inline comments.
================
Comment at: test/std/strings/basic.string/string.cons/copy_alloc.pass.cpp:123
imp2.deactivate();
test_assign(s1, s2);
----------------
BillyONeal wrote:
> We still fail this test in debug mode because we need to allocate a new
> _Container_proxy from imp2 in this assignment. Should this be libcxx_assert?
Hmmm this is copy assignment, not move assignment, so we still have a bug. I
should not try writing CR comments at 2 in the morning.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60023/new/
https://reviews.llvm.org/D60023
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
