ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.
================
Comment at: test/std/strings/basic.string/string.cons/copy_alloc.pass.cpp:125
test_assign(s1, s2);
assert(s1 == p1);
assert(s2 == p2);
----------------
BillyONeal wrote:
> This particular assert tests that the copy assignment operator provides the
> strong exception safety guarantee, but the standard requires only the basic
> guarantee. Should this be _LIBCXX_ASSERT?
Yes, I think it should (ideally with a short comment).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60023/new/
https://reviews.llvm.org/D60023
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
