ilya-biryukov added a comment. In D54796#1306960 <https://reviews.llvm.org/D54796#1306960>, @hokein wrote:
> There is one thing I'm not certain: should we stop emitting the file status > when the file is removed (similar to the behavior of diagnostics)? For > example, the file is removed while the AST is building. The current behavior > of the patch will emit them. It would be reasonable to be consistent with diagnostics: stop emitting the statuses when ASTWorker was put into shutdown mode. However, the clients will still need to handle statuses for "removed" files somehow: the notifications in the LSP are inherently racy, IIUC there's no way to serialize removeFile and status updates if we're processing the requests in a (truly) asynchronous manner. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54796/new/ https://reviews.llvm.org/D54796 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
