Szelethus added inline comments.
================
Comment at: clang-tidy/readability/RedundantPreprocessorCheck.cpp:56-59
+ StringRef SourceText =
+ Lexer::getSourceText(CharSourceRange::getTokenRange(ConditionRange),
+ PP.getSourceManager(), PP.getLangOpts());
+ std::string Condition = getCondition(SourceText);
----------------
I'm a little confused. To me, it seems like you acquired the condition already
-- doesn't `ConditionRange` actually cover the, well, condition range? This is
how I imagined it:
```
#ifdef CUTE_PANDA_CUBS
^~~~~~~~~~~~~~~
ConditionRange
```
Why is there a need for `getCondition`? Is there any? If there is (maybe the
acquired text contains other things), can you document it? I haven't played
with `PPCallbacks` much, so I'm fine with being in the wrong.
https://reviews.llvm.org/D54349
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
