vmiklos marked 2 inline comments as done.
vmiklos added inline comments.
================
Comment at: clang-tidy/readability/RedundantPreprocessorCheck.cpp:37
+ CheckMacroRedundancy(Loc, Condition, IfStack,
+ "nested redundant if; consider removing it",
+ "previous if was here", true);
----------------
aaron.ballman wrote:
> I think these diagnostics should be hoisted as private constant members of
> the class. Something like:
> `nested redundant %select{#if|#ifdef|#ifndef}0; consider removing it"` and
> `previous %select{#if|#ifdef|#ifndef}0 here`
Done, I've also added an enum to specify if/ifdef/ifndef to avoid hard-to-read
0/1/2 for these.
https://reviews.llvm.org/D54349
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
