hokein added inline comments.
================
Comment at: test/CMakeLists.txt:76
-set(llvm_utils
- FileCheck count not
- )
-
-foreach(t ${llvm_utils})
- if(TARGET ${t})
- list(APPEND CLANG_TOOLS_TEST_DEPS ${t})
- endif()
-endforeach()
-
+macro(add_llvm_utils_deps deps)
+ set(llvm_utils
----------------
sammccall wrote:
> Conversely, I'd consider just expanding these out into each of the dep lists
> rather than keeping two levels of indirection here.
>
>
Ah, I missed this comment. It seems that there is no elegant way to expand
these to `CLANG_TOOLS_TEST_DEPS` and `CLANGD_TOOLS_TEST_DEPS`, we have to
repeat the code twice. So I'd prefer using macro to eliminate code duplication.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52710
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
